Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS direction property docs should mention that it affects grid cell layout #38094

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

jswalden
Copy link
Contributor

Description

I was reading through CSS grid docs and began to consider how directionality would affect cell layout. (And also visual interpretation of grid lines -- grid line 1 would be on right instead of left if rtl -- but because the numbering remains consistent with source order this probably doesn't need to be documented.)

I saw that CSS direction docs mention effect on table cell layout but neglect to mention grid cell layout as well. This is simple to fix and syncs direction documentation to mention effect upon a relatively newer spec.

Additional details

You can readily verify this behavior by loading this example and changing the ltr class on the wrapper <div> to rtl. The second line's cell will run between column lines 2 and 4 (1-indexed) visibly differently in the two cases, according to the affected line numbering. And the first line's cells will automatically run in accordance with the applied direction.

@jswalden jswalden requested a review from a team as a code owner February 11, 2025 01:33
@jswalden jswalden requested review from estelle and removed request for a team February 11, 2025 01:33
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/CSS/direction
Title: direction
Flaw count: 2

  • broken_links:
    • /en-US/docs/Web/CSS/inheritance is ill cased
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/inheritance which is a redirect

(comment last updated: 2025-02-11 19:45:46)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit f528154 into mdn:main Feb 13, 2025
8 checks passed
@jswalden jswalden deleted the direction-grids branch February 13, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants